Batched update of factory tests.

Batched update of factory tests.

[Tammo Spalink, 2010-06-22 06:09:12]

sorry about the massive update :(
i accidentally lost my incremental state moving stuff to a freshly downloaded
code tree...

[Nick Sanders, 2010-06-22 07:34:31]

lgtm w/ additional added comments

http://codereview.chromium.org/2857012/diff/1/3
File client/site_tests/factory_Display/factory_Display.py (right):

http://codereview.chromium.org/2857012/diff/1/3#newcode8
client/site_tests/factory_Display/factory_Display.py:8: # This is an example
factory test that does not really do anything --
stale comment

http://codereview.chromium.org/2857012/diff/1/4
File client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py
(right):

http://codereview.chromium.org/2857012/diff/1/4#newcode8
client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py:8: # This
is an example factory test that does not really do anything --
stale comment

http://codereview.chromium.org/2857012/diff/1/4#newcode37
client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py:37: lssys =
utils.run('ls -d /sys/block/sd*')
/sys/block/${dev}/removable can specify if the device is removable.

http://codereview.chromium.org/2857012/diff/1/5
File client/site_tests/factory_RebootStub/factory_RebootStub.py (right):

http://codereview.chromium.org/2857012/diff/1/5#newcode8
client/site_tests/factory_RebootStub/factory_RebootStub.py:8: # This is an
example factory test that does not really do anything --
can you add a comment that the rebooting is in control, under runin reboot step
function?

http://codereview.chromium.org/2857012/diff/4001/5007
File client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py (right):

http://codereview.chromium.org/2857012/diff/4001/5007#newcode8
client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py:8: # This is an
example factory test that does not really do anything --
can you add a comment here about how this works? 

Nice generic wrapper by the way!!

http://codereview.chromium.org/2857012/diff/4001/5008
File client/site_tests/factory_Touchpad/factory_Touchpad.py (right):

http://codereview.chromium.org/2857012/diff/4001/5008#newcode20
client/site_tests/factory_Touchpad/factory_Touchpad.py:20:
_SYNCLIENT_SETTINGS_CMDLINE = '/usr/bin/synclient -l'
should we rename this factory_SynapticsTouchpad maybe, or add a comment about
that?

[Tammo Spalink, 2010-06-22 08:09:54]

http://codereview.chromium.org/2857012/diff/4001/5007
File client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py (right):

http://codereview.chromium.org/2857012/diff/4001/5007#newcode8
client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py:8: # This is an
example factory test that does not really do anything --
On 2010/06/22 07:34:31, Nick Sanders wrote:
> can you add a comment here about how this works? 
> 
> Nice generic wrapper by the way!!

Done.

http://codereview.chromium.org/2857012/diff/4001/5008
File client/site_tests/factory_Touchpad/factory_Touchpad.py (right):

http://codereview.chromium.org/2857012/diff/4001/5008#newcode20
client/site_tests/factory_Touchpad/factory_Touchpad.py:20:
_SYNCLIENT_SETTINGS_CMDLINE = '/usr/bin/synclient -l'
On 2010/06/22 07:34:31, Nick Sanders wrote:
> should we rename this factory_SynapticsTouchpad maybe, or add a comment about
> that?

Done.

[kmixter1, 2010-07-02 00:31:17]

I'm pretty late to the party here and getting factory tests up and
ready is of higher importance than refactoring code, but I hope you
agree that long term it would be better to have these just be named
"hardware_"... and be able to use them in the same contexts where we
run other tests (aka, with run_remote_tests on machines with regular
test images).  Seems to me that it would make them easier for the
whole team to contribute to and improve, and potentially makes them
individually runnable during hwqual and in other suites.

On Tue, Jun 22, 2010 at 1:09 AM,  <tammo@chromium.org> wrote:
>
> http://codereview.chromium.org/2857012/diff/4001/5007
> File client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py
> (right):
>
> http://codereview.chromium.org/2857012/diff/4001/5007#newcode8
> client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py:8: #
> This is an example factory test that does not really do anything --
> On 2010/06/22 07:34:31, Nick Sanders wrote:
>>
>> can you add a comment here about how this works?
>
>> Nice generic wrapper by the way!!
>
> Done.
>
> http://codereview.chromium.org/2857012/diff/4001/5008
> File client/site_tests/factory_Touchpad/factory_Touchpad.py (right):
>
> http://codereview.chromium.org/2857012/diff/4001/5008#newcode20
> client/site_tests/factory_Touchpad/factory_Touchpad.py:20:
> _SYNCLIENT_SETTINGS_CMDLINE = '/usr/bin/synclient -l'
> On 2010/06/22 07:34:31, Nick Sanders wrote:
>>
>> should we rename this factory_SynapticsTouchpad maybe, or add a
>
> comment about
>>
>> that?
>
> Done.
>
> http://codereview.chromium.org/2857012/show
>

[Tammo Spalink, 2010-07-02 03:43:00]

On Fri, Jul 2, 2010 at 08:31, Ken Mixter <kmixter@chromium.org> wrote:
> I'm pretty late to the party here and getting factory tests up and
> ready is of higher importance than refactoring code, but I hope you
> agree that long term it would be better to have these just be named
> "hardware_"... and be able to use them in the same contexts where we
> run other tests (aka, with run_remote_tests on machines with regular
> test images).  Seems to me that it would make them easier for the
> whole team to contribute to and improve, and potentially makes them
> individually runnable during hwqual and in other suites.

Lets talk about this when Vince and I visit MTV during the week of 12
July.  It is definitely _not_ the current long-term plan to make these
usable in the same contexts as other tests.

Tammo


> On Tue, Jun 22, 2010 at 1:09 AM,  <tammo@chromium.org> wrote:
>>
>> http://codereview.chromium.org/2857012/diff/4001/5007
>> File client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py
>> (right):
>>
>> http://codereview.chromium.org/2857012/diff/4001/5007#newcode8
>> client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py:8: #
>> This is an example factory test that does not really do anything --
>> On 2010/06/22 07:34:31, Nick Sanders wrote:
>>>
>>> can you add a comment here about how this works?
>>
>>> Nice generic wrapper by the way!!
>>
>> Done.
>>
>> http://codereview.chromium.org/2857012/diff/4001/5008
>> File client/site_tests/factory_Touchpad/factory_Touchpad.py (right):
>>
>> http://codereview.chromium.org/2857012/diff/4001/5008#newcode20
>> client/site_tests/factory_Touchpad/factory_Touchpad.py:20:
>> _SYNCLIENT_SETTINGS_CMDLINE = '/usr/bin/synclient -l'
>> On 2010/06/22 07:34:31, Nick Sanders wrote:
>>>
>>> should we rename this factory_SynapticsTouchpad maybe, or add a
>>
>> comment about
>>>
>>> that?
>>
>> Done.
>>
>> http://codereview.chromium.org/2857012/show
>>
>