Issue 2857011: Convert chromoting to pepperv2 API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857011: Convert chromoting to pepperv2 API. (Closed)

Created:
10 years, 6 months ago by awong

Modified:
9 years, 6 months ago

Reviewers:
garykac

CC:
chromium-reviews

Visibility:
Public.

Description

Convert chromoting to pepperv2 API. Currently disables use of PepperView, and HostConnection->Connect(). This is mainly an attempt to get the build working. Will re-enable functionality later. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Remove most of the unittest. #

Patch Set 3 : Delete pepper1 C++ wrapper. #

Patch Set 4 : Again #

Patch Set 5 : remove. #

Patch Set 6 : break dep #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -961 lines)			Patch
D	remoting/client/pepper/fake_browser.h	View		1 chunk	+0 lines, -61 lines	0 comments	Download
D	remoting/client/pepper/fake_browser.cc	View		1 chunk	+0 lines, -157 lines	0 comments	Download
D	remoting/client/pepper/pepper_main.cc	View		1 chunk	+0 lines, -373 lines	0 comments	Download
D	remoting/client/pepper/pepper_plugin.h	View		1 chunk	+0 lines, -106 lines	0 comments	Download
D	remoting/client/pepper/pepper_plugin.cc	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	remoting/client/plugin/chromoting_main.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	remoting/client/plugin/chromoting_plugin.h	View		3 chunks	+10 lines, -28 lines	0 comments	Download
M	remoting/client/plugin/chromoting_plugin.cc	View		4 chunks	+79 lines, -79 lines	0 comments	Download
M	remoting/client/plugin/chromoting_plugin_unittest.cc	View		1 chunk	+2 lines, -70 lines	0 comments	Download
M	remoting/client/plugin/pepper_view.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	remoting/remoting.gyp	View	1 2 3 4	4 chunks	+3 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

garykac

On 2010/06/21 22:02:30, awong wrote: > Step 1 of pepperv2 conversion. LGTM

10 years, 6 months ago (2010-06-21 22:15:50 UTC) #2

awong

I had to remove more code to make things compile. Almost all of it will ...

10 years, 6 months ago (2010-06-22 00:04:00 UTC) #3

garykac

10 years, 6 months ago (2010-06-22 00:13:49 UTC) #4

On 2010/06/22 00:04:00, awong wrote:
> I had to remove more code to make things compile. Almost all of it will be
> obsoleted in the next couple of checkins, so I think it's okay.

SLGTM

Expand Messages | Collapse Messages