Issue 2856088: Only copy the plugin if it doesn't already exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856088: Only copy the plugin if it doesn't already exist. (Closed)

Created:
10 years, 4 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Only copy the plugin if it doesn't already exist. CopyDirectory fails only on windows in this case. Not sure how it passed the try bots. TBR=stuartmorgan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54989

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/test/ui/npapi_test_helper.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

We should actually be deleting it if it exists, then do the copy, otherwise non-clean ...

10 years, 4 months ago (2010-08-04 23:56:13 UTC) #2

tony

10 years, 4 months ago (2010-08-05 00:00:12 UTC) #3

On 2010/08/04 23:56:13, stuartmorgan wrote:
> We should actually be deleting it if it exists, then do the copy, otherwise
> non-clean builds will not be correct. Unless the TODO is going to be addressed
> ASAP, this code should be fixed.

You're right.  I have the patch ready to get rid of the copy, but rather than
block on that, I'll go ahead and do a delete.

Expand Messages | Collapse Messages