Issue 2856069: Recover cookies thrown away because of duplicate creation times.

Issue 2856069: Recover cookies thrown away because of duplicate creation times. (Closed)

Created:
10 years, 4 months ago by Randy Smith (Not in Mondays)

Modified:
9 years, 7 months ago

Reviewers:
cpu1, eroman, ahendrickson

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Recover cookies thrown away because of duplicate creation times. BUG=50583 TEST=Saw bug in heapcheck, made change, saw bug dissapear. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54181

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	net/base/cookie_monster.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

Glitch in my last checkin--memory leak. If you'd give this a quick review?

10 years, 4 months ago (2010-07-28 22:29:48 UTC) #1

cpu1

fyi there are valgrind leaks related in http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(valgrind)(3)/builds/6120/steps/memory%20test:%20net/logs/stdio On 2010/07/29 00:26:07, eroman wrote: > LGTM. ...

10 years, 4 months ago (2010-07-29 01:36:34 UTC) #3

Randy Smith (Not in Mondays)

On 2010/07/29 01:36:34, cpu1 wrote: > fyi there are valgrind leaks related in > > ...

10 years, 4 months ago (2010-07-29 03:38:31 UTC) #4

eroman

Please also update the suppressions list. I found a suppression was added for this (see ...

10 years, 4 months ago (2010-07-29 06:30:04 UTC) #5

Randy Smith (Not in Mondays)

On 2010/07/29 06:30:04, eroman wrote: > Please also update the suppressions list. > I found ...

10 years, 4 months ago (2010-07-29 15:07:42 UTC) #6

cbentzel

tools/heapcheck/suppressions.txt On Thu, Jul 29, 2010 at 11:07 AM, <rdsmith@chromium.org> wrote: > On 2010/07/29 06:30:04, ...

10 years, 4 months ago (2010-07-29 15:21:37 UTC) #7

ahendrickson

10 years, 4 months ago (2010-07-29 15:47:30 UTC) #8

LGTM

On 2010/07/29 15:21:37, cbentzel wrote:
> tools/heapcheck/suppressions.txt
> 
> On Thu, Jul 29, 2010 at 11:07 AM, <mailto:rdsmith@chromium.org> wrote:
> 
> > On 2010/07/29 06:30:04, eroman wrote:
> >
> >> Please also update the suppressions list.
> >> I found a suppression was added for this (see
> >> http://codereview.chromium.org/3057017)
> >> Thanks.
> >>
> >
> > Got tools/valgrind/memcheck/suppressions.txt.  Is there a separate
> > suppression
> > file for heapcheck?  I couldn't find it.
> >
> >
> >  On Wed, Jul 28, 2010 at 8:38 PM,  <mailto:rdsmith@chromium.org> wrote:
> >> > On 2010/07/29 01:36:34, cpu1 wrote:
> >> >>
> >> >> fyi there are valgrind leaks related in
> >> >
> >> >
> >> >
> >>
> >
> >
> >
>
http://build.chromium.org/buildbot/memory/builders/Linux%25252520Tests%252525...
> >
> >> >
> >> > cpu1: Thanks for the pointer. &nbsp;It looks to me to be the same
> >> problem,
> >>
> > and
> >
> >> > should
> >> > be fixed by this change.
> >> >
> >> > (I'm going to assume that you're listed as "reviewer" only because of
> >> your
> >> > commenting, and not hold the commit for your approval; please let me
> >> know if
> >> > I
> >> > have that wrong.)
> >> >
> >> > http://codereview.chromium.org/2856069/show
> >> >
> >>
> >
> >
> >
> >
> > http://codereview.chromium.org/2856069/show
> >
>

Expand Messages | Collapse Messages