Fixed compilation errors for Windows multi-DLL build.

Fixed compilation errors for Windows multi-DLL build.

TEST=try
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53813

[Victor Wang, 2010-07-26 21:36:38]

http://codereview.chromium.org/2856063/diff/1/2
File third_party/mesa/mesa.gyp (right):

http://codereview.chromium.org/2856063/diff/1/2#newcode17
third_party/mesa/mesa.gyp:17: 'BUILD_GL32',
so it will always have DllExport even if target mesa is built as static_library?

[apatrick_chromium, 2010-07-26 21:40:18]

http://codereview.chromium.org/2856063/diff/1/2
File third_party/mesa/mesa.gyp (right):

http://codereview.chromium.org/2856063/diff/1/2#newcode17
third_party/mesa/mesa.gyp:17: 'BUILD_GL32',
Yes. But we always build mesa into a shared library and we always want to export
those functions. The .DEF file might be redundant now. I can take a look but I
worry that dllexport won't work in a static library and we'll lose some exported
entry points.

[Victor Wang, 2010-07-26 21:48:25]

On 2010/07/26 21:40:18, apatrick_chromium wrote:
> http://codereview.chromium.org/2856063/diff/1/2
> File third_party/mesa/mesa.gyp (right):
> 
> http://codereview.chromium.org/2856063/diff/1/2#newcode17
> third_party/mesa/mesa.gyp:17: 'BUILD_GL32',
> Yes. But we always build mesa into a shared library and we always want to
export
> those functions. The .DEF file might be redundant now. I can take a look but I
> worry that dllexport won't work in a static library and we'll lose some
exported
> entry points.
yes, think we should not define dllexport in a static library, do you get any
errors in mesa and osmesa by doing this?

[apatrick_chromium, 2010-07-26 22:13:20]

Removing BUILD_GL32 from the mesa static library didn't work. DllImport is
always wrong for chrome. I can do it this way though, but it means modifying the
mesa code.

[Victor Wang, 2010-07-26 22:17:14]

On 2010/07/26 22:13:20, apatrick_chromium wrote:
> Removing BUILD_GL32 from the mesa static library didn't work. DllImport is
> always wrong for chrome. I can do it this way though, but it means modifying
the
> mesa code.
Yes, that's what I confused by the GLAPI too. Does it work after you add
BUILD_GL32 to both targets?

[apatrick_chromium, 2010-07-26 23:16:24]

It works either if I add BUILD_GL32 to both targets or if I comment the
dllimport stuff in gl.h as in my most recent patch. I'm happy doing it either
way.

[Victor Wang, 2010-07-26 23:19:47]

On 2010/07/26 23:16:24, apatrick_chromium wrote:
> It works either if I add BUILD_GL32 to both targets or if I comment the
> dllimport stuff in gl.h as in my most recent patch. I'm happy doing it either
> way.
commenting the dllimport sounds better to me...

[Victor Wang, 2010-07-27 18:03:54]

LGTM

Thanks for fixing this!
On 2010/07/26 23:19:47, Victor Wang wrote:
> On 2010/07/26 23:16:24, apatrick_chromium wrote:
> > It works either if I add BUILD_GL32 to both targets or if I comment the
> > dllimport stuff in gl.h as in my most recent patch. I'm happy doing it
either
> > way.
> commenting the dllimport sounds better to me...