Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 2856053: Implement the 'Clear Browser Data' dom-ui overlay.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pref_ui.js
===================================================================
--- chrome/browser/resources/options/pref_ui.js (revision 53227)
+++ chrome/browser/resources/options/pref_ui.js (working copy)
@@ -28,8 +28,7 @@
// Listen to user events.
this.addEventListener('click',
function(e) {
- Preferences.setBooleanPref(self.pref,
- self.checked);
+ Preferences.setBooleanPref(self.pref, self.checked);
});
}
};
@@ -107,8 +106,20 @@
// Listen to user events.
this.addEventListener('change',
function(e) {
- Preferences.setStringPref(self.pref,
- self.options[self.selectedIndex].value);
+ switch(self.dataType) {
+ case 'number':
+ Preferences.setIntegerPref(self.pref,
+ self.options[self.selectedIndex].value);
+ break;
+ case 'boolean':
+ Preferences.setBooleanValue(self.pref,
+ self.options[self.selectedIndex].value);
+ break;
+ case 'string':
+ Preferences.setStringPref(self.pref,
+ self.options[self.selectedIndex].value);
+ break;
+ }
});
},
@@ -122,6 +133,8 @@
*/
initializeValues: function(options) {
options.forEach(function (values) {
+ if (this.dataType == undefined)
+ this.dataType = typeof values[0];
this.appendChild(new Option(values[1], values[0]));
}, this);
}

Powered by Google App Engine
This is Rietveld 408576698