Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/dom_ui/core_options_handler.cc

Issue 2856053: Implement the 'Clear Browser Data' dom-ui overlay.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/core_options_handler.cc
===================================================================
--- chrome/browser/dom_ui/core_options_handler.cc (revision 53227)
+++ chrome/browser/dom_ui/core_options_handler.cc (working copy)
@@ -57,6 +57,23 @@
l10n_util::GetString(
IDS_OPTIONS_SETTINGS_LANGUAGES_HANGUL_SETTINGS_TITLE));
#endif
+
+ localized_strings->SetString(L"ok",
+ l10n_util::GetString(IDS_OK));
+ localized_strings->SetString(L"cancel",
+ l10n_util::GetString(IDS_CANCEL));
+ localized_strings->SetString(L"delete",
+ l10n_util::GetString(IDS_DELETE));
+ localized_strings->SetString(L"edit",
+ l10n_util::GetString(IDS_EDIT));
+ localized_strings->SetString(L"learnMore",
+ l10n_util::GetString(IDS_LEARN_MORE));
+ localized_strings->SetString(L"abort",
+ l10n_util::GetString(IDS_ABORT));
+ localized_strings->SetString(L"close",
+ l10n_util::GetString(IDS_CLOSE));
+ localized_strings->SetString(L"done",
+ l10n_util::GetString(IDS_DONE));
}
void CoreOptionsHandler::Observe(NotificationType type,
@@ -139,8 +156,6 @@
if (param_values->GetSize() < kMinFetchPrefsParamCount)
return;
- size_t idx = param_values->GetSize();
- LOG(INFO) << "param_values->GetSize() = " << idx;
// Get callback JS function name.
Value* callback;
if (!param_values->Get(0, &callback) || !callback->IsType(Value::TYPE_STRING))
@@ -229,8 +244,6 @@
if (!value || !value->IsType(Value::TYPE_LIST))
return;
const ListValue* param_values = static_cast<const ListValue*>(value);
- size_t size = param_values->GetSize();
- LOG(INFO) << "Array size = " << size;
if (param_values->GetSize() != 2)
return;

Powered by Google App Engine
This is Rietveld 408576698