Issue 2856043: Fix crash in SSLClientSocketPool:GetLoadState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856043: Fix crash in SSLClientSocketPool:GetLoadState (Closed)

Created:
10 years, 5 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fix crash in SSLClientSocketPool:GetLoadState ClientSocketHandle::GetLoadState is only valid when the handle doesn't have a socket. And we repeat the DoTunnelConnectComplete state when when need to restart the http proxy with authentication - after the transport_socket_handle_ has been assigned the http proxy socket. BUG=41408 TEST=amended SSLClientSocketPoolTest.DoProxyAuth Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52781

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	net/socket/ssl_client_socket_pool.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	net/socket/ssl_client_socket_pool_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages