Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2856042: [Mac] Implement the update available notification in the wrench menu. (Closed)

Created:
10 years, 5 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

[Mac] Implement the update available notification in the wrench menu. The changes to restart_browser.mm also affect the sheet displayed in the About window. Note that the badge on the wrench menu looks bad. BUG=45147 TEST=difficult Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52911

Patch Set 1 #

Total comments: 6

Patch Set 2 : Observe notification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -27 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +16 lines, -6 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/menu_controller.mm View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/restart_browser.mm View 1 4 chunks +24 lines, -6 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 1 7 chunks +49 lines, -9 lines 0 comments Download
M chrome/browser/wrench_menu_model.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
http://cl.ly/87272d74c840a39a3c2c
10 years, 5 months ago (2010-07-16 21:35:58 UTC) #1
Mark Mentovai
The wart should also show up on the wrenches of already-open windows if an upgrade ...
10 years, 5 months ago (2010-07-16 21:46:21 UTC) #2
Robert Sesek
All comments addressed. The ToolbarController now gets messaged when the UPGRADE_RECOMMENDED notification gets posted. Tested ...
10 years, 5 months ago (2010-07-16 22:41:47 UTC) #3
Mark Mentovai
10 years, 5 months ago (2010-07-19 03:22:53 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698