gclient: fetch only what's needed

gclient: fetch only what's needed

To reduce server load, only fetch the ref we need.

TEST=ran presubmit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52941

[Nasser Grainawi, 2010-07-16 14:13:24]

One minor comment.

http://codereview.chromium.org/2856038/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/2856038/diff/1/2#newcode262
gclient_scm.py:262: ['fetch'] + verbose + ['origin'] + [revision],
Instead of 'origin', could you grab the remote name from upstream_branch?

[petkov, 2010-07-16 18:38:00]

LGTM AFAICT but wait for the other reviewers.

One comment/suggestion below.

Note that this change won't solve the issue of changing DEPS to the new remote
branch and then everybody starting to get that new branch.

http://codereview.chromium.org/2856038/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/2856038/diff/1/2#newcode260
gclient_scm.py:260: if current_type == "branch":
Does it make sense and is it easy to provide a gclient option to go back to the
previous behavior? Something like --git-fetch-all or --no-git-fetch...

[M-A Ruel, 2010-07-16 23:01:28]

random note: I'd like to have a general alternate fetch mechanism, mainly for
git-svn users but that's totally unrelated to this patch :)

lgtm

http://codereview.chromium.org/2856038/diff/1/2
File gclient_scm.py (right):

http://codereview.chromium.org/2856038/diff/1/2#newcode262
gclient_scm.py:262: ['fetch'] + verbose + ['origin'] + [revision],
nit:
['fetch'] + verbose + ['origin', revision],

[Mandeep Singh Baines, 2010-07-19 19:54:00]

On 2010/07/16 14:13:24, Nasser Grainawi wrote:
> One minor comment.
> 
> http://codereview.chromium.org/2856038/diff/1/2
> File gclient_scm.py (right):
> 
> http://codereview.chromium.org/2856038/diff/1/2#newcode262
> gclient_scm.py:262: ['fetch'] + verbose + ['origin'] + [revision],
> Instead of 'origin', could you grab the remote name from upstream_branch?

upstream_branch is the current branch you have checked out while I want the
branch specified in the DEPS. origin is safe (but ugly) because we use clone. At
some point it might be nice to remove the origin assumption.

[Daniel Erat, 2010-07-20 16:25:12]

On 2010/07/19 19:54:00, Mandeep Singh Baines wrote:
> On 2010/07/16 14:13:24, Nasser Grainawi wrote:
> > One minor comment.
> > 
> > http://codereview.chromium.org/2856038/diff/1/2
> > File gclient_scm.py (right):
> > 
> > http://codereview.chromium.org/2856038/diff/1/2#newcode262
> > gclient_scm.py:262: ['fetch'] + verbose + ['origin'] + [revision],
> > Instead of 'origin', could you grab the remote name from upstream_branch?
> 
> upstream_branch is the current branch you have checked out while I want the
> branch specified in the DEPS. origin is safe (but ugly) because we use clone.
At
> some point it might be nice to remove the origin assumption.

I think that this change broke stuff.  I'm going to revert it unless someone
else beats me to it:

  File "/home/derat/local/depot_tools/gclient.py", line 1208, in <module>
    sys.exit(Main(sys.argv[1:]))
  File "/home/derat/local/depot_tools/gclient.py", line 1198, in Main
    return command(parser, argv[1:])
  File "/home/derat/local/depot_tools/gclient.py", line 1035, in CMDsync
    return client.RunOnDeps('update', args)
  File "/home/derat/local/depot_tools/gclient.py", line 621, in RunOnDeps
    scm.RunCommand(command, self._options, args, file_list)
  File "/home/derat/local/depot_tools/gclient_scm.py", line 115, in RunCommand
    return getattr(self, command)(options, args, file_list)
  File "/home/derat/local/depot_tools/gclient_scm.py", line 264, in update
    print_error=False)
  File "/home/derat/local/depot_tools/scm.py", line 84, in Capture
    return gclient_utils.CheckCall(c, in_directory, print_error)
  File "/home/derat/local/depot_tools/gclient_utils.py", line 58, in CheckCall
    raise CheckCallError(command, cwd, process.returncode, std_out, std_err)
gclient_utils.CheckCallError: (['git', 'fetch', 'origin', 'cc1c63d'],
'/usr/local/google/home/derat/chrome/src/third_party/cros', 128, '', "fatal:
Couldn't find remote ref cc1c63d\nfatal: The remote end hung up unexpectedly\n")
Sending crash report ...
A stack trace has been sent to the maintainers.