Issue 2856028: [Linux]When cancelling a composition, only focus out/in the IM context when it has focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856028: [Linux]When cancelling a composition, only focus out/in the IM context when it has focus. (Closed)

Created:
10 years, 5 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato, satorux1

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Linux]When cancelling a composition, only focus out/in the IM context when it has focus. BUG=http://crosbug.com/4449 TEST=See bug report. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51480

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/renderer_host/gtk_im_context_wrapper.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Su

Hope this CL can fix the bug. I actually can't reproduce this issue on Linux ...

10 years, 5 months ago (2010-07-01 20:02:14 UTC) #1

satorux1

LGTM. Confirmed that the change fix the ime issue on the chromium os netbook. On ...

10 years, 5 months ago (2010-07-02 02:25:42 UTC) #3

Yusuke Sato

10 years, 5 months ago (2010-07-02 02:42:12 UTC) #4

LGTM

the change fixed the problem on my end, too.

On 2010/07/02 02:25:42, satorux1 wrote:
> LGTM.
> 
> Confirmed that the change fix the ime issue on the chromium os netbook.
> 
> On 2010/07/02 01:48:32, satorux1 wrote:
> >

Expand Messages | Collapse Messages