Issue 2856022: Added support to GLEW for dynamically looking up the core WGL entry...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856022: Added support to GLEW for dynamically looking up the core WGL entry... (Closed)

Created:
10 years, 5 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added support to GLEW for dynamically looking up the core WGL entry points to avoid the need to link against opengl32.lib. Added _ATL_NO_OPENGL #define in build/common.gypi to prevent link directive from forcibly pulling in opengl32.lib for any Chrome code using ATL. Once upstream code in WebKit is changed to use the new wglew entry points and remove opengl32.lib from the link line, chrome.dll will no longer depend on opengl32.dll. BUG=45586 TEST=ran WebGL with --in-process-webgl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51277

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -1 line)			Patch
M	build/common.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/glew/README.chromium	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/glew/include/GL/wglew.h	View	3 chunks	+48 lines, -0 lines	0 comments	Download
M	third_party/glew/src/glew.c	View	5 chunks	+53 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages