Issue 2856008: Revert revision 50247 "Move DEPS parsing into a single function."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2856008: Revert revision 50247 "Move DEPS parsing into a single function." (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Revert revision 50247 "Move DEPS parsing into a single function." It breaks on Windows. TBR=msb Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50248

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -63 lines)			Patch
	M	gclient.py	View		11 chunks	+82 lines, -63 lines	0 comments	Download

Total messages: 3 (0 generated)

msb

LGTM On Fri, Jun 18, 2010 at 9:47 AM, <maruel@chromium.org> wrote: > Reviewers: Mandeep Singh ...

10 years, 6 months ago (2010-06-18 17:27:40 UTC) #2

rubberstamp LGTM