Issue 2855034: Separate out additional cmd line args to chroot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2855034: Separate out additional cmd line args to chroot (Closed)

Created:
10 years, 5 months ago by amartin

Modified:
9 years, 7 months ago

Reviewers:
tedbo, Mandeep Singh Baines, bdavirro, djmm

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Separate out additional cmd line args to chroot This fix separates out any additional command line arguments given to the enter_chroot.sh script when passed to the interior chroot. This allows one to pass environment variable settings to the interior chroot shell such as: ./enter_chroot.sh -- CHROME_ORIGIN=LOCAL_SOURCE emerge-x86-generic ... Before this fix any of these variable settings will be sucked up by the shell launching the chroot, not the interior shell. BUG=chromium-os:2457 TEST=ran test cases detailed in bug report

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	enter_chroot.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages