Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Side by Side Diff: src/arm/assembler-arm.cc

Issue 2855018: X64: Change strategy for spilling to match ia32. It's just better. (Closed)
Patch Set: Addressed review comments Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 382
383 383
384 void Assembler::Align(int m) { 384 void Assembler::Align(int m) {
385 ASSERT(m >= 4 && IsPowerOf2(m)); 385 ASSERT(m >= 4 && IsPowerOf2(m));
386 while ((pc_offset() & (m - 1)) != 0) { 386 while ((pc_offset() & (m - 1)) != 0) {
387 nop(); 387 nop();
388 } 388 }
389 } 389 }
390 390
391 391
392 void Assembler::CodeTargetAlign() {
393 Align(16); // Tentative value.
394 }
395
396
392 bool Assembler::IsNop(Instr instr, int type) { 397 bool Assembler::IsNop(Instr instr, int type) {
393 // Check for mov rx, rx. 398 // Check for mov rx, rx.
394 ASSERT(0 <= type && type <= 14); // mov pc, pc is not a nop. 399 ASSERT(0 <= type && type <= 14); // mov pc, pc is not a nop.
395 return instr == (al | 13*B21 | type*B12 | type); 400 return instr == (al | 13*B21 | type*B12 | type);
396 } 401 }
397 402
398 403
399 bool Assembler::IsBranch(Instr instr) { 404 bool Assembler::IsBranch(Instr instr) {
400 return (instr & (B27 | B25)) == (B27 | B25); 405 return (instr & (B27 | B25)) == (B27 | B25);
401 } 406 }
(...skipping 1931 matching lines...) Expand 10 before | Expand all | Expand 10 after
2333 2338
2334 // Since a constant pool was just emitted, move the check offset forward by 2339 // Since a constant pool was just emitted, move the check offset forward by
2335 // the standard interval. 2340 // the standard interval.
2336 next_buffer_check_ = pc_offset() + kCheckConstInterval; 2341 next_buffer_check_ = pc_offset() + kCheckConstInterval;
2337 } 2342 }
2338 2343
2339 2344
2340 } } // namespace v8::internal 2345 } } // namespace v8::internal
2341 2346
2342 #endif // V8_TARGET_ARCH_ARM 2347 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.h ('k') | src/codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698