Load net-internals from the newly created resources.pak file.

Load net-internals from the newly created resources.pak file.

This patch also forces the loading of the optional DataPack for const correctness reasons

BUG=35793, 42770
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50057

[tony, 2010-06-15 23:40:26]

LGTM! Thanks for const-ifying stuff!

http://codereview.chromium.org/2855003/diff/2001/3001
File app/resource_bundle.cc (right):

http://codereview.chromium.org/2855003/diff/2001/3001#newcode211
app/resource_bundle.cc:211: // Always preload the data packs so we can maintain
constness.
Ok, but please watch the perf bots (probably won't matter, but just to be safe).

http://codereview.chromium.org/2855003/diff/2001/3005
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/2855003/diff/2001/3005#newcode334
chrome/browser/dom_ui/net_internals_ui.cc:334: for (size_t i = 0; i <
kNetInternalsResourcesSize; ++i) {
I guess kNetInternalsResourcesSize is small so this is probably just as fast as
a map.

[tony, 2010-06-16 00:57:29]

Oh, one more thing, we can now remove the net_internals_resources target in gyp.
 This can be in a follow up change.

[Elliot Glaysher, 2010-06-16 01:05:41]

On 2010/06/16 00:57:29, tony wrote:
> Oh, one more thing, we can now remove the net_internals_resources target in
gyp.
>  This can be in a follow up change.

Updated. I think this is what you're asking for, but I'm not sure...

[tony, 2010-06-16 01:11:44]

Yup, that's right.  LGTM!

[Elliot Glaysher, 2010-06-16 19:31:33]

On 2010/06/16 01:11:44, tony wrote:
> Yup, that's right.  LGTM!

OK, I modified this to work on mac. There were problems with looking for
"resource.pak" in whatever specific bundle directory. I am not sure this is the
best solution though. I don't really know this code.

I'm theorizing that the window trybots are flake, though I'm running them again.

TAL? (chrome_paths.cc to be specific)

[tony, 2010-06-17 00:16:21]

LGTM

http://codereview.chromium.org/2855003/diff/12001/13008
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/2855003/diff/12001/13008#newcode250
chrome/common/chrome_paths.cc:250: cur =
cur.Append(FILE_PATH_LITERAL("Resources"));
Ah yes, this looks right.