autotest: create a candidate script for replacement ebuild test (running the tests)

autotest: create a candidate script for replacement ebuild test (running the tests)

* This script should replace the call to ebuild in autotest wrapper, and essentially
duplicates all the test running functions from autotest-0.0.1.ebuild

* duplicate autotest wrapper into autotest_workon to separate conversion and old functionality

* Add a hack into run_remote_tests to allow using autotest_workon instead

	new file:   autotest_run.sh
        new file:   autotest_workon
        modified:   run_remote_tests.sh

[anush, 2010-07-23 00:57:35]

We will be installing the script in the chroot in the future. Please rename
to cros_autotest instead and put it in crosutils:bin/.

Thanks

On Thu, Jul 22, 2010 at 5:29 PM, <zbehan@chromium.org> wrote:

> Reviewers: Mandeep Singh Baines, anush, ericli,
>
> Description:
> autotest: create a candidate script for replacement ebuild test (running
> the
> tests)
>
> * This script should replace the call to ebuild in autotest wrapper, and
> essentially
> duplicates all the test running functions from autotest-0.0.1.ebuild
>
>        new file:   autotest_run.sh
>
> Please review this at http://codereview.chromium.org/2854062/show
>
> SVN Base: ssh://gitrw.chromium.org/crosutils
>
> Affected files:
>  A autotest_run.sh
>
>
> Index: autotest_run.sh
> diff --git a/autotest_run.sh b/autotest_run.sh
> new file mode 100755
> index
>
0000000000000000000000000000000000000000..7ec7cab5afccc6374f105eed0fdf10ae3b9ee458
> --- /dev/null
> +++ b/autotest_run.sh
> @@ -0,0 +1,82 @@
> +#!/bin/bash
> +
> +# Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
> +# Use of this source code is governed by a BSD-style license that can be
> +# found in the LICENSE file.
> +
> +# This script is intended as a wrapper to execute autotest tests for a
> given
> +# board.
> +
> +# Load common constants.  This should be the first executable line.
> +# The path to common.sh should be relative to your script's location.
> +. "$(dirname "$0")/common.sh"
> +
> +# Script must be run inside the chroot
> +restart_in_chroot_if_needed $*
> +get_default_board
> +
> +DEFINE_string board "${DEFAULT_BOARD}" \
> +  "The board to run tests for."
> +
> +FLAGS_HELP="usage: $0 <flags>"
> +FLAGS "$@" || exit 1
> +eval set -- "${FLAGS_ARGV}"
> +
> +# Define a directory which will not be cleaned by portage automatically.
> So we
> +# could achieve incremental build between two autoserv runs.
> +# NOTE(zbehan): This is the legacy location
>
>
+BUILD_STAGE="/build/${FLAGS_board}/tmp/portage/chromeos-base/autotest-0.0.1/staging"
> +#BUILD_STAGE="/build/${FLAGS_board}/var/lib/autotest/"
> +
> +# Ensure the configures run by autotest pick up the right config.site
> +CONFIG_SITE=/usr/share/config.site
> +AUTOTEST_SRC="${CHROMEOS_ROOT}/src/third_party/autotest/files"
> +
> +[ -z "${FLAGS_board}" ] && \
> +  die "You must specify --board="
> +
> +function setup_ssh() {
> +  eval $(ssh-agent) > /dev/null
> +  ssh-add \
> +    ${CHROMEOS_ROOT}/src/scripts/mod_for_test_scripts/ssh_keys/testing_rsa
> +}
> +
> +function teardown_ssh() {
> +  ssh-agent -k > /dev/null
> +}
> +
> +function copy_src() {
> +  local dst=$1
> +  mkdir -p "${dst}"
> +  cp -fpru "${AUTOTEST_SRC}"/{client,conmux,server,tko,utils} "${dst}" ||
> die
> +  cp -fpru "${AUTOTEST_SRC}/shadow_config.ini" "${dst}" || die
> +}
> +
> +src_test() {
> +  local third_party="${CHROMEOS_ROOT}/src/third_party"
> +  copy_src "${BUILD_STAGE}"
> +  cp -fpru "${AUTOTEST_SRC}/global_config.ini" "${BUILD_STAGE}"
> +
> +  sudo chown -R ${SUDO_UID}:${SUDO_GID} "${BUILD_STAGE}"
> +  sudo chmod -R 755 "${BUILD_STAGE}"
> +
> +  setup_ssh
> +  cd "${BUILD_STAGE}"
> +
> +  setup_cross_toolchain
> +
> +  local args=()
> +  if [[ -n ${AUTOSERV_TEST_ARGS} ]]; then
> +    args=("-a" "${AUTOSERV_TEST_ARGS}")
> +  fi
> +
> +  local timestamp=$(date +%Y-%m-%d-%H.%M.%S)
> +
> +  # Do not use sudo, it'll unset all your environment
> +  LOGNAME=${SUDO_USER} ./server/autoserv -r /tmp/results.${timestamp} \
> +    ${AUTOSERV_ARGS} "${args[@]}"
> +
> +  teardown_ssh
> +}
> +
> +src_test
>
>
>

[ericli, 2010-07-23 03:19:03]

Seems like nobody will use this script for now and no existing test routine has
been changed.

And the code snippet is copied out from autotest ebuild file.

I will simply LGTM this and keep the ball rolling.

We can discuss in more details next Monday face to face.

Thanks!

[zbehan, 2010-07-23 05:23:45]

I'm planning to switch autotest wrapper to start using this and wipe this
particular code from the ebuild.

For now, we can easilly test if this works by making a local change into
autotest wrapper. The function should essentially be identical, and this
should be a drop-in replacement for the ebuild call. If it isn't, it should
be fixed, or the call in autotest wrapper slightly bent to accomodate the
differences.

This change is required for any reasonable split of the autotest ebuild,
also from the philosophical point of view, this piece of code was entirely
misplaced in the ebuild, because it does not build anything and does not
test anything that has been built. Instead it runs the product of the
ebuild.

Also, I'm definitely hoping to have some work done on this before Monday, at
the very least so that I have much better idea of the scope and scale of
what is there to do.

On Thu, Jul 22, 2010 at 8:19 PM, <ericli@chromium.org> wrote:

> Seems like nobody will use this script for now and no existing test routine
> has
> been changed.
>
> And the code snippet is copied out from autotest ebuild file.
>
> I will simply LGTM this and keep the ball rolling.
>
> We can discuss in more details next Monday face to face.
>
> Thanks!
>
>
> http://codereview.chromium.org/2854062/show
>

[ericli, 2010-07-27 00:50:13]

LGTM.

[ericli, 2010-07-27 01:00:42]

LGTM