Issue 2854055: Send UnlockCompleted signal even if screen lock is already present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2854055: Send UnlockCompleted signal even if screen lock is already present. (Closed)

Created:
10 years, 5 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
krasimira1, David James

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Send UnlockCompleted signal even if screen lock is already present. BUG=chromium-os:4827 TEST=new test TestShowTwice Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53241

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/login/screen_locker.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/login/screen_locker_browsertest.cc	View	1	4 chunks	+35 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

oshima

Krasimira Can you review this? It seems like David didn't have time to review before ...

10 years, 5 months ago (2010-07-21 20:12:52 UTC) #2

LGTM