Issue 2854029: Add PhysicalDisable command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2854029: Add PhysicalDisable command. (Closed)

Created:
10 years, 5 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, gauravsh

Base URL:
ssh://git@chromiumos-git/tpm_lite.git

Visibility:
Public.

Patch Set 3 : . #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -13 lines)			Patch
M	src/tlcl/generator.c	View	1 2	9 chunks	+19 lines, -11 lines	0 comments	Download
M	src/tlcl/structures.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/tlcl/tlcl.h	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/tlcl/tlcl.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/tlcl/version.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

lgtm http://codereview.chromium.org/2854029/diff/1/5 File src/tlcl/tlcl.h (right): http://codereview.chromium.org/2854029/diff/1/5#newcode130 src/tlcl/tlcl.h:130: /* Issues a PhysicalEnable. The TPM error code ...

10 years, 5 months ago (2010-06-29 20:15:21 UTC) #2

Luigi Semenzato

10 years, 5 months ago (2010-06-29 20:26:21 UTC) #3

On Tue, Jun 29, 2010 at 1:15 PM,  <gauravsh@chromium.org> wrote:
> lgtm
>
>
> http://codereview.chromium.org/2854029/diff/1/5
> File src/tlcl/tlcl.h (right):
>
> http://codereview.chromium.org/2854029/diff/1/5#newcode130
> src/tlcl/tlcl.h:130: /* Issues a PhysicalEnable.  The TPM error code is
> returned.
> Is PhysicalEnable the same as SetEnable? i.e. can someone confuse
> between the two?

Confusing choice of names.  The commands are called PhysicalEnable and
PhysicalDisable.  The PhysicalEnable sets the enable flag, so I called
it setenable.  I suppose I could change everything to the TPM command
name.

Expand Messages | Collapse Messages

Issue 2854029: Add PhysicalDisable command. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Better name. #

Patch Set 3 : . #

Messages