Issue 2854009: Avoid unnecessary recompilation on mac when enabling/disabling distcc. Always...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2854009: Avoid unnecessary recompilation on mac when enabling/disabling distcc. Always... (Closed)

Created:
10 years, 6 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
mutex

CC:
chromium-reviews

Base URL:
http://swtoolkit.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Submitting for: mutex Avoid unnecessary recompilation on mac when enabling/disabling distcc. Always change the compiler name to the full path, regardless of whether we have distcc enabled. Next, put "$( $)" markers around the DISTCC compiler name to signal so that scons ignores changes to distcc activity. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -6 lines)			Patch
	M	site_scons/site_tools/distcc.py	View		2 chunks	+38 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thanks Brad for submitting this upstream.

Expand Messages | Collapse Messages