Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2017)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 2853032: Add a DOM UI version of ibus-hangul configuration dialog. (Closed)
Patch Set: '' Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/chromeos_language_hangul_options.js ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 7d8eb35bb369694e36cf758025b18b3063bcf76f..055b21ad455c78b864f6f6375faef4964040b9bd 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -132,16 +132,15 @@ PrefSelect.prototype = {
/**
* Sets up options in select element.
* @param {Array} options List of option and their display text.
- * Each string in the array contains options value and display text split
- * with '|' character.
+ * Each element in the array is an array of length 2 which contains options
+ * value in the first element and display text in the second element.
*
* TODO(zelidrag): move this to that i18n template classes.
*/
initializeValues: function(options) {
var self = this;
- options.forEach(function (option) {
- var values = option.split('|');
- self.appendChild(new Option(values[1], values[0], false, false));
+ options.forEach(function (values) {
+ self.appendChild(new Option(values[1], values[0]));
});
},
/**
« no previous file with comments | « chrome/browser/resources/options/chromeos_language_hangul_options.js ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698