Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2853024: Remove the bookmark menu. (Closed)

Created:
10 years, 5 months ago by Peter Kasting
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Remove the bookmark menu. BUG=none TEST=--bookmark-menu no longer does anything Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51403

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -367 lines) Patch
D chrome/app/theme/menu_bookmark.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_theme_pack.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/browser_theme_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/gtk/bookmark_menu_controller_gtk.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_menu_controller_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/view_id_util.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/gtk/view_id_util_browsertest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/view_ids.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +4 lines, -6 lines 0 comments Download
D chrome/browser/views/bookmark_menu_button.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/views/bookmark_menu_button.cc View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.h View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/views/bookmark_menu_controller_views.cc View 6 chunks +3 lines, -27 lines 0 comments Download
M chrome/browser/views/toolbar_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 9 chunks +2 lines, -26 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M views/controls/button/menu_button.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Peter Kasting
10 years, 5 months ago (2010-06-30 23:17:30 UTC) #1
sky
Sadness. LGTM
10 years, 5 months ago (2010-06-30 23:50:47 UTC) #2
tmcb82
Hi, Why was this removed? It is an EXTREMELY handy feature! Thanks for your input.
10 years, 5 months ago (2010-07-02 17:55:55 UTC) #3
Espiox
On 2010/07/02 17:55:55, tmcb82 wrote: > Hi, > > Why was this removed? It is ...
10 years, 5 months ago (2010-07-02 18:17:09 UTC) #4
dlevine3_gmail.com
Please put this feature back. The one downside to Chrome on Windows is that a ...
10 years, 5 months ago (2010-07-02 18:29:40 UTC) #5
AnotherCanuck
Please revert this change. This was a very popular feature and a necessity for many. ...
10 years, 5 months ago (2010-07-02 18:30:25 UTC) #6
mitokens
Bad Google. I liked that menu. Now I have to deal with lackluster, inefficient, sluggish, ...
10 years, 5 months ago (2010-07-02 18:50:55 UTC) #7
dziga
Yes, I want it back! It worked great, much better than similar extensions!
10 years, 5 months ago (2010-07-02 22:44:05 UTC) #8
cowell.chris
Hi, please keep the bookmark bar. It is very handy to have to my favorite ...
10 years, 5 months ago (2010-07-03 02:22:16 UTC) #9
cowell.chris
On 2010/07/03 02:22:16, cowell.chris wrote: > Hi, please keep the bookmark bar. It is very ...
10 years, 5 months ago (2010-07-03 02:22:37 UTC) #10
Peter Kasting
Just so you all know, commenting here has absolutely zero effect on our plans. It's ...
10 years, 5 months ago (2010-07-03 02:42:50 UTC) #11
AnotherCanuck
On 2010/07/03 02:42:50, Peter Kasting wrote: > Just so you all know, commenting here has ...
10 years, 5 months ago (2010-07-03 02:45:14 UTC) #12
Peter Kasting
The same as it always is: chromium-discuss@chromium.org, or the bug tracker. In this case, the ...
10 years, 5 months ago (2010-07-03 02:50:26 UTC) #13
Jayayess1190
Do not do this, not everyone wants all there bookmarks on the bookmarks bar (aka ...
10 years, 5 months ago (2010-07-03 03:12:01 UTC) #14
Jayayess1190
On 2010/07/03 03:12:01, Jayayess1190 wrote: > Do not do this, not everyone wants all there ...
10 years, 5 months ago (2010-07-03 03:13:51 UTC) #15
Espiox
On 2010/07/03 02:50:26, Peter Kasting wrote: > The same as it always is: mailto:chromium-discuss@chromium.org, or ...
10 years, 5 months ago (2010-07-03 09:08:29 UTC) #16
Cakalaky
I agree, we should have the option to have the bookmark menu available until another ...
10 years, 5 months ago (2010-07-09 20:20:46 UTC) #17
guardianJ
"was agreed upon by a couple different UI leads" isn't any real explanation. Why was ...
10 years, 5 months ago (2010-07-09 20:41:41 UTC) #18
evarist.monjo
I can't understant it... Chrome wants to be minimal, but we have to spent space ...
10 years, 5 months ago (2010-07-09 23:29:40 UTC) #19
ermaly
<<I already posted comments on a few bugs in our > database about the way ...
10 years, 5 months ago (2010-07-09 23:34:05 UTC) #20
Peter Kasting
This is not an appropriate place to debate this change. As noted above, these sorts ...
10 years, 5 months ago (2010-07-09 23:43:10 UTC) #21
jonas.maj
Google once again proves they are clueless when it comes to desktop applications. Bookmarks menu ...
10 years, 5 months ago (2010-07-25 09:49:24 UTC) #22
an9227
Please return this feature in Chrome. It's very useful.
10 years, 4 months ago (2010-08-02 16:23:06 UTC) #23
QQ510371827
On 2010/08/02 16:23:06, an9227 wrote: > Please return this feature in Chrome. It's very useful. ...
10 years, 3 months ago (2010-08-29 11:27:10 UTC) #24
Tiss
Please bring back the bookmark menu!
10 years, 3 months ago (2010-09-10 10:34:08 UTC) #25
LJStoneman
Looks like I'll be going back to Firefox until this much needed feature is returned. ...
10 years, 3 months ago (2010-09-12 22:36:12 UTC) #26
jwaltrip
10 years, 3 months ago (2010-09-19 18:10:20 UTC) #27
What a damnfool change.  Switching back to Firefox.

Powered by Google App Engine
This is Rietveld 408576698