Issue 2853006: Added setting the locale on startup to the initial_locale attribute in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2853006: Added setting the locale on startup to the initial_locale attribute in... (Closed)

Created:
10 years, 6 months ago by dr

Modified:
9 years, 7 months ago

Reviewers:
glotov

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added setting the locale on startup to the initial_locale attribute in startup customization manifest. BUG=http://crosbug.com/3176 TEST=Run out/Debug/chrome --login-manager --startup-manifest=chrome/browser/chromeos/testdata/startup_manifest.json. Welcome message should be in Italian. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49958

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
M	chrome/browser/chromeos/login/language_switch_model.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/language_switch_model.cc	View		2 chunks	+15 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/testdata/startup_manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

glotov

10 years, 6 months ago (2010-06-16 14:34:58 UTC) #2

LGTM

http://codereview.chromium.org/2853006/diff/4001/5003
File chrome/browser/chromeos/login/wizard_controller.cc (right):

http://codereview.chromium.org/2853006/diff/4001/5003#newcode253
chrome/browser/chromeos/login/wizard_controller.cc:253: std::string locale =
customization_->initial_locale();
nit: const

Expand Messages | Collapse Messages