Issue 2852047: Fix concurrent access to VMState::current_state_.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852047: Fix concurrent access to VMState::current_state_. (Closed)

Created:
10 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Visibility:
Public.

Description

Fix concurrent access to VMState::current_state_. The main fix is for current_state() and external_callback() accessors. I also applied memory access ordering on current_state_ modification, mainly to reflect the fact that it is being shared among VM and profiler sampler threads. BUG=361 Committed: http://code.google.com/p/v8/source/detail?r=5035

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -8 lines)			Patch
M	src/vm-state.h	View	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/vm-state.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/vm-state-inl.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM but we might need to add some annotations to make ThreadSanitizer happy.

10 years, 5 months ago (2010-07-07 15:40:53 UTC) #2

mnaganov (inactive)

10 years, 5 months ago (2010-07-07 16:16:22 UTC) #3

On 2010/07/07 15:40:53, Vitaly wrote:
> LGTM but we might need to add some annotations to make ThreadSanitizer happy.

Annotations require depending on 'dynamic_annotations' package. It is included
in Chromium, but not in V8.

Expand Messages | Collapse Messages