Issue 2852035: [gcc] Make nacl calls CALLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852035: [gcc] Make nacl calls CALLs. (Closed)

Created:
10 years, 5 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@chromiumos-git/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] Make nacl calls CALLs. Change nacl calls from UNSPEC (fnaddr) to CALL (MEM (UNSPEC (fnaddr))). In places where gcc processes CALLs, we copy-pasted the code for nacl calls implemented via UNSPEC_NACLCALL. Now we remove these changes.

Patch Set 1 #

Patch Set 2 : ready for code review #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -60 lines)			Patch
M	gcc/gcc/config/i386/i386.c	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	gcc/gcc/config/i386/i386.md	View	12 chunks	+24 lines, -24 lines	0 comments	Download
M	gcc/gcc/dwarf2out.c	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	gcc/gcc/final.c	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gcc/gcc/reg-stack.c	View	1 chunk	+3 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

10 years, 5 months ago (2010-06-30 10:49:53 UTC) #2

LGTM

This is a very nice cleanup! Although this may theoretically affect I suggest
postponing it until we have a buildbot running.

Expand Messages | Collapse Messages