Issue 2852033: Archive debug artifacts - take two

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2852033: Archive debug artifacts - take two (Closed)

Created:
10 years, 5 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
robotboy, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git//crosutils.git

Visibility:
Public.

Description

Archive debug artifacts - take two

Patch Set 1 #

Total comments: 1

Patch Set 2 : Respond to review #

Patch Set 3 : Reapply gsutil fix #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -12 lines)			Patch
	M	archive_build.sh	View	1 2	4 chunks	+25 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kmixter1

Try archiving artifacts again, this time without sudo -v which causes requires a password on ...

10 years, 5 months ago (2010-06-30 01:27:52 UTC) #1

sosa

10 years, 5 months ago (2010-06-30 03:25:13 UTC) #2

Nit o/w lgtm

http://codereview.chromium.org/2852033/diff/1/2
File archive_build.sh (right):

http://codereview.chromium.org/2852033/diff/1/2#newcode214
archive_build.sh:214: if [ "$FLAGS_gsutil_archive" != "" ]
Use -n

Expand Messages | Collapse Messages