Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: net/spdy/spdy_session.h

Issue 2852029: Revert "Streams send a Rst frame upon being closed by client. Some minor editorial fixes." (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 95267907ddc4d533c4be4c618d9cc346d284f904..8a23168b9e5fac1f05711c566ee773a38bcce8f1 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -91,16 +91,8 @@ class SpdySession : public base::RefCounted<SpdySession>,
int WriteStreamData(spdy::SpdyStreamId stream_id, net::IOBuffer* data,
int len);
- // This marks the stream as half closed from the client side, and removes it
- // from the active_streams_ map.
- void CloseStream(spdy::SpdyStreamId id, int status);
- // This is identical to CloseStream, except it also sends a Rst stream frame.
- void CloseStreamAndSendRst(spdy::SpdyStreamId stream_id, int status);
-
- // Half close a stream.
- void HalfCloseStreamClientSide(spdy::SpdyStreamId stream_id, int status);
- void HalfCloseStreamServerSide(spdy::SpdyStreamId stream_id, int status);
-
+ // Close a stream.
+ void CloseStream(spdy::SpdyStreamId stream_id, int status);
// Check if a stream is active.
bool IsStreamActive(spdy::SpdyStreamId stream_id) const;
@@ -150,7 +142,7 @@ class SpdySession : public base::RefCounted<SpdySession>,
const linked_ptr<spdy::SpdyHeaderBlock>& headers);
void OnSynReply(const spdy::SpdySynReplyControlFrame& frame,
const linked_ptr<spdy::SpdyHeaderBlock>& headers);
- void OnRst(const spdy::SpdyRstStreamControlFrame& frame);
+ void OnFin(const spdy::SpdyRstStreamControlFrame& frame);
void OnGoAway(const spdy::SpdyGoAwayControlFrame& frame);
void OnSettings(const spdy::SpdySettingsControlFrame& frame);
@@ -189,6 +181,7 @@ class SpdySession : public base::RefCounted<SpdySession>,
// Track active streams in the active stream list.
void ActivateStream(SpdyStream* stream);
+ void DeleteStream(spdy::SpdyStreamId id, int status);
// Removes this session from the session pool.
void RemoveFromPool();
@@ -277,7 +270,7 @@ class SpdySession : public base::RefCounted<SpdySession>,
int streams_initiated_count_;
int streams_pushed_count_;
int streams_pushed_and_claimed_count_;
- int streams_abandoned_count_; // # of streams that were pushed & abandoned.
+ int streams_abandoned_count_;
bool sent_settings_; // Did this session send settings when it started.
bool received_settings_; // Did this session receive at least one settings
// frame.
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698