Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2852022: Add debug.tgz debug info archive as buildbot artifact (Closed)

Created:
10 years, 6 months ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov, djmm
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git//crosutils.git
Visibility:
Public.

Description

Add debug.tgz debug info archive as buildbot artifact BUG=4263

Patch Set 1 #

Total comments: 1

Patch Set 2 : Respond to review #

Patch Set 3 : Do not change perms in the SYSROOT, run tar as root instead #

Patch Set 4 : Add sudo -v #

Patch Set 5 : rebase #

Patch Set 6 : Remove accidental sudo -v #

Patch Set 7 : Fix recent bug causing a unary operator expected syntax error #

Patch Set 8 : Move above GS archival - but dont use it yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M archive_build.sh View 1 2 3 4 5 6 7 4 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kmixter1
10 years, 6 months ago (2010-06-24 01:31:27 UTC) #1
petkov
LGTM w/ a comment you might want to address, and djmm should really comment on ...
10 years, 6 months ago (2010-06-24 04:23:07 UTC) #2
djmm
I would like if our build scripts had less sudos, but I don't see away ...
10 years, 6 months ago (2010-06-24 04:40:59 UTC) #3
kmixter1
10 years, 6 months ago (2010-06-24 07:16:34 UTC) #4
Responded to review - changed root directory and removed all sudo's (none were
necessary if I ran it standalone and built all 3 modded images before archiving
debug).

Pushing...

Powered by Google App Engine
This is Rietveld 408576698