Provide a default definition of the target_arch variable on Linux to...

Provide a default definition of the target_arch variable on Linux to
work around a problem in NaCl's GYP files where it infers 32-bit on
Linux in native_client/build/common.gypi.

A fix in Native Client and a DEPS roll in O3D are still needed to make
the Linux build fully work with the newer NaCl.

BUG=none
TEST=built O3D on Linux


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49817

[Ken Russell (switch to Gerrit), 2010-06-15 02:18:37]

Please review. Thanks.

[apatrick, 2010-06-15 15:38:15]

LGTM

http://codereview.chromium.org/2851003/diff/1/2
File build/common_global.gypi (right):

http://codereview.chromium.org/2851003/diff/1/2#newcode21
build/common_global.gypi:21: 'target_arch%': '<!(uname -m | sed -e
"s/i.86/ia32/;s/x86_64/x64/;s/arm.*/arm/")'
Does "uname -p" produce output closer to what you need for target_arch?

[Ken Russell (switch to Gerrit), 2010-06-15 19:06:05]

http://codereview.chromium.org/2851003/diff/1/2
File build/common_global.gypi (right):

http://codereview.chromium.org/2851003/diff/1/2#newcode21
build/common_global.gypi:21: 'target_arch%': '<!(uname -m | sed -e
"s/i.86/ia32/;s/x86_64/x64/;s/arm.*/arm/")'
On 2010/06/15 15:38:15, apatrick wrote:
> Does "uname -p" produce output closer to what you need for target_arch?

This variable setting was copied from, and needs to be exactly the same as in,
NaCl's build/common.gypi. I've added a comment indicating this.

[apatrick_chromium, 2010-06-15 20:02:19]

LGTM