Issue 2850045: Allow python to find gtk module. (originally nsanders CL)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2850045: Allow python to find gtk module. (originally nsanders CL) (Closed)

Created:
10 years, 5 months ago by Tammo Spalink

Modified:
9 years, 7 months ago

Reviewers:
Nick Sanders, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

Allow python to find gtk module. (originally nsanders CL) BUG=4464 TEST=manually edit file so far

Patch Set 1 #

Total comments: 3

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	build_image	View		1 chunk	+8 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Wai-Hong Tam

LGTM http://codereview.chromium.org/2850045/diff/1/2 File build_image (right): http://codereview.chromium.org/2850045/diff/1/2#newcode426 build_image:426: sudo bash -c "\ Why don't you just ...

10 years, 5 months ago (2010-07-07 02:46:00 UTC) #2

Tammo Spalink

http://codereview.chromium.org/2850045/diff/1/2 File build_image (right): http://codereview.chromium.org/2850045/diff/1/2#newcode426 build_image:426: sudo bash -c "\ On 2010/07/07 02:46:00, Tom Wai-Hong ...

10 years, 5 months ago (2010-07-07 02:52:30 UTC) #3

Tom Wai-Hong Tam

10 years, 5 months ago (2010-07-07 03:14:45 UTC) #4

http://codereview.chromium.org/2850045/diff/1/2
File build_image (right):

http://codereview.chromium.org/2850045/diff/1/2#newcode426
build_image:426: sudo bash -c "\
You are right. Not work with redirect. Keep the original one.

Expand Messages | Collapse Messages