Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: webkit/tools/test_shell/test_shell.cc

Issue 2850042: Deprecate more old filepath functions. (Closed)
Patch Set: rebase Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/tools/test_shell/test_shell.cc
diff --git a/webkit/tools/test_shell/test_shell.cc b/webkit/tools/test_shell/test_shell.cc
index 63de00b8d3a9c890ea2f8eb52a24a3d462757b2a..a73dc9582e8d4773438d983057e6855411044bbc 100644
--- a/webkit/tools/test_shell/test_shell.cc
+++ b/webkit/tools/test_shell/test_shell.cc
@@ -325,7 +325,7 @@ void TestShell::Dump(TestShell* shell) {
// static
std::string TestShell::DumpImage(skia::PlatformCanvas* canvas,
- const std::wstring& file_name, const std::string& pixel_hash) {
+ const FilePath& path, const std::string& pixel_hash) {
skia::BitmapPlatformDevice& device =
static_cast<skia::BitmapPlatformDevice&>(canvas->getTopPlatformDevice());
const SkBitmap& src_bmp = device.accessBitmap(false);
@@ -371,7 +371,7 @@ std::string TestShell::DumpImage(skia::PlatformCanvas* canvas,
static_cast<int>(src_bmp.rowBytes()), discard_transparency, &png);
// Write to disk.
- file_util::WriteFile(file_name, reinterpret_cast<const char *>(&png[0]),
+ file_util::WriteFile(path, reinterpret_cast<const char *>(&png[0]),
png.size());
}
@@ -692,7 +692,7 @@ void TestShell::GoBackOrForward(int offset) {
}
void TestShell::DumpDocumentText() {
- std::wstring file_path;
+ FilePath file_path;
if (!PromptForSaveFile(L"Dump document text", &file_path))
return;
@@ -702,7 +702,7 @@ void TestShell::DumpDocumentText() {
}
void TestShell::DumpRenderTree() {
- std::wstring file_path;
+ FilePath file_path;
if (!PromptForSaveFile(L"Dump render tree", &file_path))
return;

Powered by Google App Engine
This is Rietveld 408576698