Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: base/file_util_unittest.cc

Issue 2850042: Deprecate more old filepath functions. (Closed)
Patch Set: rebase Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index fd54963eba93ab8667d05efee73fb1e6a9843d3f..7acf00c4640bb2b1ad58f981ff1d32aea194423e 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -292,6 +292,8 @@ static const struct InsertBeforeExtensionCase {
#endif
};
+#if defined(OS_WIN)
+// This function has been deprecated on non-Windows.
TEST_F(FileUtilTest, InsertBeforeExtensionTest) {
for (unsigned int i = 0; i < arraysize(kInsertBeforeExtension); ++i) {
FilePath path(kInsertBeforeExtension[i].path);
@@ -299,6 +301,7 @@ TEST_F(FileUtilTest, InsertBeforeExtensionTest) {
EXPECT_EQ(kInsertBeforeExtension[i].result, path.value());
}
}
+#endif
static const struct filename_case {
const wchar_t* path;
@@ -363,6 +366,8 @@ static const struct extension_case {
#endif
};
+#if defined(OS_WIN)
+// This function has been deprecated on non-Windows.
TEST_F(FileUtilTest, GetFileExtensionFromPath) {
for (unsigned int i = 0; i < arraysize(extension_cases); ++i) {
const extension_case& ext = extension_cases[i];
@@ -370,6 +375,7 @@ TEST_F(FileUtilTest, GetFileExtensionFromPath) {
EXPECT_EQ(ext.extension, fext);
}
}
+#endif
// Test finding the directory component of a path
static const struct dir_case {

Powered by Google App Engine
This is Rietveld 408576698