Issue 2850037: If we're setting a frame's content settings based on its opener,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2850037: If we're setting a frame's content settings based on its opener,... (Closed)

Created:
10 years, 5 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org, Chris Evans

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

If we're setting a frame's content settings based on its opener, null check the opener's WebView before using it. BUG=42974 TEST=Flaky, no known repro steps

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/renderer/render_view.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages