Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/plugin_installer.cc

Issue 2850031: plugins: Show a help link in the "plugin needed" infobar. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: rebased Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugin_installer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugin_installer.cc
diff --git a/chrome/browser/plugin_installer.cc b/chrome/browser/plugin_installer.cc
index b7f38c537c4b92a03a07d4b14a7e2c4825a56d78..2d0e0a3fbf79690490954044c4874b344b5ce572 100644
--- a/chrome/browser/plugin_installer.cc
+++ b/chrome/browser/plugin_installer.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,6 +10,7 @@
#include "chrome/browser/renderer_host/render_view_host.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "grit/generated_resources.h"
+#include "grit/locale_settings.h"
#include "grit/theme_resources.h"
#include "webkit/glue/plugins/default_plugin_shared.h"
@@ -65,3 +66,15 @@ bool PluginInstaller::Accept() {
tab_contents_->render_view_host()->InstallMissingPlugin();
return true;
}
+
+std::wstring PluginInstaller::GetLinkText() {
+ return l10n_util::GetString(IDS_PLUGININSTALLER_PROBLEMSINSTALLING);
+}
+
+bool PluginInstaller::LinkClicked(WindowOpenDisposition disposition) {
+ // Ignore the click dispostion and always open in a new top level tab.
+ tab_contents_->OpenURL(
+ GURL(l10n_util::GetStringUTF8(IDS_LEARN_MORE_PLUGININSTALLER_URL)),
+ GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
+ return false; // Do not dismiss the info bar.
+}
« no previous file with comments | « chrome/browser/plugin_installer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698