Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2850031: plugins: Show a help link in the "plugin needed" infobar. (Closed)

Created:
10 years, 6 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Glen Murphy, jam, ananta
CC:
chromium-reviews, jam, finnur+watch_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org, A S Alam
Base URL:
git://git.chromium.org/chromium.git
Visibility:
Public.

Description

plugins: Show a help link in the "plugin needed" infobar. BUG=6574 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52808

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/app/resources/locale_settings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/plugin_installer.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/plugin_installer.cc View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
Hi Glenn, could you review this to me?
10 years, 5 months ago (2010-07-08 16:04:58 UTC) #1
Glenn Wilson
On 2010/07/08 16:04:58, tfarina wrote: > Hi Glenn, could you review this to me? I'm ...
10 years, 5 months ago (2010-07-08 16:31:19 UTC) #2
jam
Ananta is most familiar with the plugin installer, I defer to him
10 years, 5 months ago (2010-07-08 18:34:04 UTC) #3
ananta
10 years, 5 months ago (2010-07-08 20:49:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698