Issue 2850001: add battery driver in st1.5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2850001: add battery driver in st1.5 (Closed)

Created:
10 years, 6 months ago by Benson Leung

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/kernel.git

Visibility:
Public.

Description

add battery driver in st1.5 BUG=NONE TEST=Built and ran on st1.5 Signed-off-by: Horace Fu <horace.fu@quantatw.com>; Review URL: http://codereview.chromium.org/1637005 (cherry picked from commit 2fffb8921503d2fc3a1d7ecf5e52c8512bfd9b18) Signed-off-by: Benson Leung <bleung@chromium.org>;

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+426 lines, -0 lines)			Patch
M	drivers/power/Kconfig	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	drivers/power/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	drivers/power/qci_battery.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	drivers/power/qci_battery.c	View	1 chunk	+356 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mandeep Singh Baines

10 years, 6 months ago (2010-06-14 21:41:11 UTC) #2

LGTM

bleung@chromium.org (bleung@chromium.org) wrote:
> Reviewers: Mandeep Singh Baines,
>
> Description:
> add battery driver in st1.5
>
> BUG=NONE
> TEST=Built and ran on st1.5
> Signed-off-by: Horace Fu <horace.fu@quantatw.com>
>
> Review URL: http://codereview.chromium.org/1637005
> (cherry picked from commit 2fffb8921503d2fc3a1d7ecf5e52c8512bfd9b18)
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
>
> Please review this at http://codereview.chromium.org/2850001/show
>
> SVN Base: ssh://gitrw.chromium.org/kernel.git
>
> Affected files:
>   M drivers/power/Kconfig
>   M drivers/power/Makefile
>   A drivers/power/qci_battery.h
>   A drivers/power/qci_battery.c
>
>

Expand Messages | Collapse Messages