Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2850: Generalize the Function.prototype.call hooks in the... (Closed)

Created:
12 years, 3 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Generalize the Function.prototype.call hooks in the arguments adaptor code to allow builtins to work without argument adaptor frames. Get rid of unused JavaScript implementation of call and apply and the associated code generation hooks. Committed: http://code.google.com/p/v8/source/detail?r=311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -576 lines) Patch
M src/bootstrapper.cc View 1 chunk +22 lines, -18 lines 0 comments Download
M src/builtins.h View 4 chunks +3 lines, -4 lines 0 comments Download
M src/builtins-arm.cc View 3 chunks +154 lines, -152 lines 0 comments Download
M src/builtins-ia32.cc View 3 chunks +135 lines, -132 lines 0 comments Download
M src/codegen.h View 1 chunk +1 line, -10 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/codegen-arm.cc View 4 chunks +0 lines, -62 lines 0 comments Download
M src/codegen-ia32.cc View 2 chunks +0 lines, -74 lines 0 comments Download
M src/objects.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/v8natives.js View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
12 years, 3 months ago (2008-09-15 13:51:20 UTC) #1
iposva
12 years, 3 months ago (2008-09-15 14:38:34 UTC) #2
LGTM

-Ivan

Powered by Google App Engine
This is Rietveld 408576698