Issue 2849031: Get remoting.gyp depending only on the bits of gfx we need to depend on....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2849031: Get remoting.gyp depending only on the bits of gfx we need to depend on.... (Closed)

Created:
10 years, 5 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
garykac, Alpha Left Google

CC:
chromium-reviews, Sergey Ulanov, dmac, awong, Alpha Left Google, TVL

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Get remoting.gyp depending only on the bits of gfx we need to depend on. BUG=none TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51268

Patch Set 1 #

Total comments: 1

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	remoting/remoting.gyp	View		3 chunks	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

garykac

On 2010/06/29 20:29:01, dmac wrote: > We don't need to depend on gfx unittests LGTM

10 years, 5 months ago (2010-06-29 20:36:47 UTC) #2

garykac

10 years, 5 months ago (2010-06-29 20:36:58 UTC) #3

http://codereview.chromium.org/2849031/diff/1/2
File remoting/remoting.gyp (right):

http://codereview.chromium.org/2849031/diff/1/2#newcode198
remoting/remoting.gyp:198:
'$(SDKROOT)/System/Library/Frameworks/OpenGL.framework',
Just checking that this was an intended part of your gfx.gyp:gfx changes.

Expand Messages | Collapse Messages