src/date.js - Issue 2848038: Fix bug in date code where -0 was not mapped to 0. This caused the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/date.js

Issue 2848038: Fix bug in date code where -0 was not mapped to 0. This caused the ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/date.js

===================================================================

--- src/date.js (revision 5011)

+++ src/date.js (working copy)

@@ -347,9 +347,10 @@

function MakeDay(year, month, date) {

if (!$isFinite(year) || !$isFinite(month) || !$isFinite(date)) return $NaN;

- year = TO_INTEGER(year);

- month = TO_INTEGER(month);

- date = TO_INTEGER(date);

+ // Convert to integer and map -0 to 0.

+ year = TO_INTEGER_MAP_MINUS_ZERO(year);

+ month = TO_INTEGER_MAP_MINUS_ZERO(month);

+ date = TO_INTEGER_MAP_MINUS_ZERO(date);

if (year < kMinYear || year > kMaxYear ||

month < kMinMonth || month > kMaxMonth ||

« no previous file with comments | « no previous file | src/macros.py » ('j') | test/mjsunit/date.js » ('J')