Issue 2848038: Fix bug in date code where -0 was not mapped to 0. This caused the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2848038: Fix bug in date code where -0 was not mapped to 0. This caused the ... (Closed)

Created:
10 years, 5 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug in date code (issue 736) where -0 was not mapped to 0. This caused the runtime system to throw an exception because it expected smi arguments. Committed: http://code.google.com/p/v8/source/detail?r=5013

Patch Set 1 #

Total comments: 2

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	src/date.js	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/macros.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/mjsunit/date.js	View	1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/2848038/diff/1/5 File test/mjsunit/date.js (right): http://codereview.chromium.org/2848038/diff/1/5#newcode160 test/mjsunit/date.js:160: assertDoesNotThrow("new Date(-0, -0, -0, -0, -0, -0. -0)"); ...

10 years, 5 months ago (2010-07-02 19:59:47 UTC) #2

Mads Ager (chromium)

10 years, 5 months ago (2010-07-02 20:07:07 UTC) #3

http://codereview.chromium.org/2848038/diff/1/5
File test/mjsunit/date.js (right):

http://codereview.chromium.org/2848038/diff/1/5#newcode160
test/mjsunit/date.js:160: assertDoesNotThrow("new Date(-0, -0, -0, -0, -0, -0.
-0)");
On 2010/07/02 19:59:47, Erik Corry wrote:
> Perhaps we should also pass 0x40000000 and -0x40000001 to check that
almost-Smis
> work.

Done.

Expand Messages | Collapse Messages