Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2848032: Clear function breakpoints in Debug::HandleWeakDebugInfo callback. (Closed)

Created:
10 years, 5 months ago by podivilov
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Clear function breakpoints in Debug::HandleWeakDebugInfo callback. When removing debug_info from SharedFunctionInfo, clear all breakpoints associated with that debug_info. This is needed because function will live in heap until next gc, and therefore can be found by Runtime::FindSharedFunctionInfoInScript. Committed: http://code.google.com/p/v8/source/detail?r=4997

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M src/debug.cc View 1 chunk +2 lines, -0 lines 1 comment Download
M test/cctest/test-debug.cc View 2 chunks +34 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
podivilov
10 years, 5 months ago (2010-06-30 11:30:50 UTC) #1
podivilov
10 years, 5 months ago (2010-06-30 11:33:31 UTC) #2
Søren Thygesen Gjesse
10 years, 5 months ago (2010-06-30 11:52:23 UTC) #3
LGTM

http://codereview.chromium.org/2848032/diff/1/2
File src/debug.cc (right):

http://codereview.chromium.org/2848032/diff/1/2#newcode686
src/debug.cc:686: DebugInfoListNode* node =
reinterpret_cast<DebugInfoListNode*>(data);
Please add a comment on why this is required.

http://codereview.chromium.org/2848032/diff/1/3
File test/cctest/test-debug.cc (right):

http://codereview.chromium.org/2848032/diff/1/3#newcode2079
test/cctest/test-debug.cc:2079: // function which is already a garbage but is
not collected so far.
is already a garbage but is not collected so far-> has no references but has not
been collected yet

Powered by Google App Engine
This is Rietveld 408576698