Issue 2848030: [Mac] Remove the nacl clobber hook, GYP seems to have all the deps handing se...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2848030: [Mac] Remove the nacl clobber hook, GYP seems to have all the deps handing se... (Closed)

Created:
10 years, 5 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Remove the nacl clobber hook, GYP seems to have all the deps handing setup right for Xcode (when expressed in the .gyp files). So this shouldn't be needed any more. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51119

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -51 lines)			Patch
	M	DEPS	View		1 chunk	+0 lines, -7 lines	0 comments	Download
	D	build/mac/clobber_generated_headers.py	View		1 chunk	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

TVL

Brad - the email thread didn't get any replies, so I'm voting we nuke it ...

10 years, 5 months ago (2010-06-28 16:26:06 UTC) #1

LGTM

Expand Messages | Collapse Messages