Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2848018: Adding dependencies for side effect files. (Closed)

Created:
10 years, 6 months ago by Sean Parent
Modified:
9 years, 7 months ago
Reviewers:
Randall Spangler, adlr
CC:
chromium-os-reviews_chromium.org
Base URL:
http://src.chromium.org/git/update_engine.git
Visibility:
Public.

Description

Adding dependencies for side effect files. BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M SConstruct View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sean Parent
env.SideEffect doesn't quite work - it assumes that the rule always generates a file with ...
10 years, 6 months ago (2010-06-22 18:09:41 UTC) #1
adlr
LGTM Maybe I should work harder for better SConstruct files, but usually if it correctly ...
10 years, 6 months ago (2010-06-22 19:25:56 UTC) #2
Randall Spangler
10 years, 6 months ago (2010-06-22 19:51:00 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698