vboot_firmware/linktest/main.c - Issue 2848006: Refactor LoadFrmware() to avoid global variables, which don't work when running out of ROM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vboot_firmware/linktest/main.c

Issue 2848006: Refactor LoadFrmware() to avoid global variables, which don't work when running out of ROM (Closed) Base URL: ssh://gitrw.chromium.org/vboot_reference.git

Patch Set: Undo change to vboot_struct Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vboot_firmware/linktest/main.c

diff --git a/vboot_firmware/linktest/main.c b/vboot_firmware/linktest/main.c

index 169b657824596f6cfd78f2406a39ff133e14fdc9..10500809d4ea298115593c62b44be4642ca4dd1b 100644

--- a/vboot_firmware/linktest/main.c

+++ b/vboot_firmware/linktest/main.c

@@ -37,7 +37,6 @@ int main(void)

GetLogicalKernelVersion(0);

/* load_firmware_fw.h */

- UpdateFirmwareBodyHash(0, 0);

LoadFirmware(0);

/* load_kernel_fw.h */

@@ -77,6 +76,8 @@ int main(void)

VerifyMemberInside(0, 0, 0, 0, 0, 0);

VerifyPublicKeyInside(0, 0, 0);

VerifySignatureInside(0, 0, 0);

+ PublicKeyInit(0, 0, 0);

+ PublicKeyCopy(0, 0);

PublicKeyToRSA(0);

VerifyData(0, 0, 0);

VerifyDigest(0, 0, 0);

@@ -88,7 +89,7 @@ int main(void)

LoadKernel2(0);

/* vboot_firmware.h */

- UpdateFirmwareBodyHash2(0, 0);

+ UpdateFirmwareBodyHash(0, 0, 0);

LoadFirmware2(0);

return 0;

« no previous file with comments | « vboot_firmware/lib/vboot_firmware.c ('k') | vboot_firmware/stub/load_firmware_stub.c » ('j') | no next file with comments »