GTTF: Ensure that when we're testing the logging system will not display dialogs.

GTTF: Ensure that when we're testing the logging system will not display dialogs.

When I was running ui_tests on Linux at the end there were to xmessage windows
on the screen. They shouldn't be there, and they might gum up the bots,
especially if it happens on Windows.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54180

[Paweł Hajdan Jr., 2010-07-28 22:00:14]

I was considering using a constant for the name of the env variable, and I still
think it's a good idea. Do you have any suggestions where should such constant
be declared?

[nsylvain, 2010-07-29 00:05:52]

Why is it not passing --noerrdialogs instead?

[Paweł Hajdan Jr., 2010-07-29 00:09:25]

This way it's just impossible to forget to pass the setting. When using
command-line flags, it's so easy to forget it in one place.

[brettw, 2010-07-29 00:53:44]

Previously I was noncommittal between the environment and a switch,
but that's because I didn't realize we already had a switch. I think
it would be better to use the existing switch. This fits better with
how things are normally done, and presumably we are already (or should
be) passing this to all relevant sub-processes.

[Paweł Hajdan Jr., 2010-07-29 19:34:31]

Updated the patch to use the flag. Tested on my machine, still no xmessages.

Nicolas, thanks for the suggestion.

Please take another look.

[nsylvain, 2010-07-29 19:43:01]

LGTM

[brettw, 2010-07-29 21:15:12]

LGTM2