Issue 2847045: URLs with repeated domain names requesting tracking information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2847045: URLs with repeated domain names requesting tracking information (Closed)

Created:
10 years, 5 months ago by bulach

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, Allan

Visibility:
Public.

Description

URLs with repeated domain names requesting tracking information Check URLs for repeated domain names then if there are any repeated show the port information of the URL as before if you had two of the same domain allowed/blocked only one would show in the bubble. Also added some unit tests for it. (landing on behalf of allanwoj. original review at http://codereview.chromium.org/2832044/show). BUG=40163 TEST=Two requests within a tab for tracking information with same domain but different port eg http://www.example.com and https://www.example.com A test fixture called ShowPortOnSameDomain is in GeolocationSettingsStateTests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51521

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -2 lines)			Patch
	M	chrome/browser/geolocation/geolocation_settings_state.cc	View		1 chunk	+19 lines, -2 lines	0 comments	Download
	M	chrome/browser/geolocation/geolocation_settings_state_unittest.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download