Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2847037: ARM: Fix GC bug with previous change... (Closed)

Created:
10 years, 5 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM: Fix GC bug with previous change The change in r4990 contained a bug in Math.pow. One of the arguments for the call to runtime where clobbered if allocation of the heap number for the result failed. Caught by a couple of Mozilla tests which does a lot of calls to Math.pow. Fix presubmit error in x64. Committed: http://code.google.com/p/v8/source/detail?r=4993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 5 months ago (2010-06-30 13:33:01 UTC) #1
Erik Corry
10 years, 5 months ago (2010-06-30 13:34:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698