Add a simple UI test for --app mode.

Add a simple UI test for --app mode.

The --app browser launch code path was previously untested, which resulted in us shipping a release where it was broken.

BUG=47544
TEST=ui_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51100

[scherkus (not reviewing), 2010-06-29 01:21:28]

My extension code broke --app mode :(

[Evan Martin, 2010-06-29 01:23:52]

LGTM, you are awesome for writing this

http://codereview.chromium.org/2847032/diff/1/2
File chrome/browser/browser_uitest.cc (right):

http://codereview.chromium.org/2847032/diff/1/2#newcode311
chrome/browser/browser_uitest.cc:311: test_file =
test_file.AppendASCII("title1.html");
Does this exist?  If so, I wouldn't call it a "dummy URL", but rather something
about how the file contents don't matter much.

http://codereview.chromium.org/2847032/diff/1/2#newcode319
chrome/browser/browser_uitest.cc:319: TEST_F(AppModeTest, EnableAppModeTest) {
Can you put a comment above this summarizing what it's intending to test?  E.g.
"that a basic app shows up ok".

http://codereview.chromium.org/2847032/diff/1/2#newcode324
chrome/browser/browser_uitest.cc:324: // Check if browser is an application.
s/check if/verify/ to match above

[scherkus (not reviewing), 2010-06-29 01:50:48]

thanks for review

will check in after try results

http://codereview.chromium.org/2847032/diff/1/2
File chrome/browser/browser_uitest.cc (right):

http://codereview.chromium.org/2847032/diff/1/2#newcode311
chrome/browser/browser_uitest.cc:311: test_file =
test_file.AppendASCII("title1.html");
On 2010/06/29 01:23:52, Evan Martin wrote:
> Does this exist?  If so, I wouldn't call it a "dummy URL", but rather
something
> about how the file contents don't matter much.

copied from other tests, but yes it does exist

I'll update all the comments

http://codereview.chromium.org/2847032/diff/1/2#newcode319
chrome/browser/browser_uitest.cc:319: TEST_F(AppModeTest, EnableAppModeTest) {
On 2010/06/29 01:23:52, Evan Martin wrote:
> Can you put a comment above this summarizing what it's intending to test? 
E.g.
> "that a basic app shows up ok".

Done.

http://codereview.chromium.org/2847032/diff/1/2#newcode324
chrome/browser/browser_uitest.cc:324: // Check if browser is an application.
On 2010/06/29 01:23:52, Evan Martin wrote:
> s/check if/verify/ to match above

Done.