Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2847028: Create a "whitespace" file used for making non-code related changes for triggering builds. (Closed)

Created:
10 years, 6 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Create a "whitespace" file used for making non-code related changes for triggering builds. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
A build/whitespace_file.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
10 years, 6 months ago (2010-06-24 19:16:29 UTC) #1
M-A Ruel
should it be svn:eol-style=lf? :) lgtm
10 years, 6 months ago (2010-06-25 01:34:45 UTC) #2
Robert Sesek
On 2010/06/25 01:34:45, Marc-Antoine Ruel wrote: > should it be svn:eol-style=lf? :) I use git. ...
10 years, 6 months ago (2010-06-25 14:57:40 UTC) #3
M-A Ruel
On 2010/06/25 14:57:40, rsesek wrote: > On 2010/06/25 01:34:45, Marc-Antoine Ruel wrote: > > should ...
10 years, 6 months ago (2010-06-25 15:16:24 UTC) #4
Robert Sesek
10 years, 6 months ago (2010-06-25 16:01:15 UTC) #5
On 2010/06/25 15:16:24, Marc-Antoine Ruel wrote:
> On 2010/06/25 14:57:40, rsesek wrote:
> > On 2010/06/25 01:34:45, Marc-Antoine Ruel wrote:
> > > should it be svn:eol-style=lf? :)
> > 
> > I use git. I have my .subversion/config set correctly, so don't these take
> > affect at dcommit time?
> 
> Yes but I don't think .txt is in the example autoprops. It doesn't matter much
> anyway.

.txt is in the autoprops list and it appears to have worked on dcommit:

$ srcer proplist -v //chrome/build/whitespace_file.txt
Properties on
'svn://svn.chromium.org/chrome/trunk/src/build/whitespace_file.txt':
  svn:eol-style
    LF

Powered by Google App Engine
This is Rietveld 408576698