Notify metrics daemon of kernel crashes.

Notify metrics daemon of kernel crashes.

BUG=none
TEST=unit tests, ran crash_reporter --init on the device

[petkov, 2010-06-17 21:37:02]

... it feels like there should be a TouchFile file_util.

[kmixter1, 2010-06-21 14:18:03]

LGTM

On Thu, Jun 17, 2010 at 2:37 PM,  <petkov@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Message:
> ... it feels like there should be a TouchFile file_util.
>
>
> Description:
> Notify metrics daemon of kernel crashes.
>
> BUG=none
> TEST=unit tests, ran crash_reporter --init on the device
>
> Please review this at http://codereview.chromium.org/2847017/show
>
> SVN Base: ssh://git@chromiumos-git/crash.git
>
> Affected files:
>  M crash_reporter.cc
>
>
> Index: crash_reporter.cc
> diff --git a/crash_reporter.cc b/crash_reporter.cc
> index
>
e283322dab15b1c2c1640866755bd6bf5f7fe182..4a5ece43c69dc9f9a74d278020a68dae9d2bb509
> 100644
> --- a/crash_reporter.cc
> +++ b/crash_reporter.cc
> @@ -25,6 +25,7 @@ DEFINE_bool(unclean_check, true, "Check for unclean
> shutdown");
>  static const char kCrashCounterHistogram[] = "Logging.CrashCounter";
>  static const char kUncleanShutdownFile[] =
>     "/var/lib/crash_reporter/pending_clean_shutdown";
> +static const char kEmpty[] = "";
>
>  // Enumeration of kinds of crashes to be used in the CrashCounter
> histogram.
>  enum CrashKinds {
> @@ -58,13 +59,19 @@ static void CheckUncleanShutdown() {
>     s_system_log.LogError("Failed to delete unclean shutdown file %s",
>                           kUncleanShutdownFile);
>   }
> +
> +  // Touch a file to notify the metrics daemon that a kernel crash has
> +  // been detected so that it can log the time since the last kernel
> +  // crash.
> +  static const char kKernelCrashDetectedFile[] =
> "/tmp/kernel-crash-detected";
> +  FilePath crash_detected(kKernelCrashDetectedFile);
> +  file_util::WriteFile(crash_detected, kEmpty, 0);
>  }
>
>  static bool PrepareUncleanShutdownCheck() {
> -  static const char empty[] = "";
>   FilePath file_path(kUncleanShutdownFile);
>   file_util::CreateDirectory(file_path.DirName());
> -  return file_util::WriteFile(file_path, empty, 0) == 0;
> +  return file_util::WriteFile(file_path, kEmpty, 0) == 0;
>  }
>
>  static void SignalCleanShutdown() {
>
>
>

[petkov, 2010-06-24 18:34:38]

sosa, could you please review -- I've added the FEATURES=test fix to the same
CL.

[sosa, 2010-06-24 18:40:52]

LGTM